Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ffmpeg-normalize: init at 1.15.7 #82595

Merged
merged 1 commit into from Mar 15, 2020
Merged

pythonPackages.ffmpeg-normalize: init at 1.15.7 #82595

merged 1 commit into from Mar 15, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Mar 14, 2020 •
edited

Motivation for this change

New Python module for normalizing audio via ffmpeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Mar 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be used as an application or python library. or both?

pkgs/development/python-modules/ffmpeg-normalize/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ffmpeg-normalize/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ffmpeg-normalize/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ffmpeg-normalize/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer reviewed Mar 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just meant to be used as an application?

pkgs/development/python-modules/ffmpeg-normalize/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ffmpeg-normalize/default.nix Outdated Show resolved Hide resolved
@prusnak
Copy link
Member Author

prusnak commented Mar 14, 2020

You are right, this should be packaged as an application. Addressed in 324f9b2

@ofborg ofborg bot removed the 6.topic: python label Mar 14, 2020
jonringer
jonringer approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
shows usage

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82595
1 package built:
ffmpeg-normalize

@jonringer jonringer merged commit 931dd07 into NixOS:master Mar 15, 2020
@prusnak prusnak deleted the python-ffmpeg-normalize branch March 15, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @jonringer