Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailscale: init at 0.96-33 #82537

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

martinbaillie
Copy link
Contributor

Motivation for this change

This PR introduces a module for enabling Tailscale—the easiest, most secure way to use WireGuard and 2FA.

CCing @danderson of Tailscale and also a regular contributor to Nixpkgs to help field any questions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danderson
Copy link
Contributor

Verified that the derivation builds correctly, and that the version number matches other Tailscale distro releases (the versioning is a bit fragile upstream right now, so it's not easy to figure out which commit hash == which version number).

nixos/modules/services/networking/tailscale.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tailscale.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tailscale.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tailscale.nix Outdated Show resolved Hide resolved
@martinbaillie martinbaillie force-pushed the add-tailscale branch 2 times, most recently from e43c1b3 to 54ab359 Compare March 14, 2020 07:00
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s clarify what exactly this software is — wasn’t clear to me at first.

pkgs/servers/tailscale/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tailscale.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/tailscale.nix Outdated Show resolved Hide resolved
Signed-off-by: Martin Baillie <martin@baillie.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants