Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xidlehook: 0.8.0 -> 0.8.2 #82682

Merged
merged 1 commit into from Mar 28, 2020
Merged

xidlehook: 0.8.0 -> 0.8.2 #82682

merged 1 commit into from Mar 28, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Mar 15, 2020

@jD91mZM2 does this package even make sense on macOS?

@jD91mZM2
Copy link
Member

@Mic92 Can you run an X server on macOS?

@Mic92
Copy link
Member Author

Mic92 commented Mar 24, 2020

@jD91mZM2 yes you can, but I am not sure if it have the APIs for what your tools does. Should we just disable macOS because the build is broken.

@jD91mZM2
Copy link
Member

Sure /shrug

@Mic92
Copy link
Member Author

Mic92 commented Mar 28, 2020

@GrahamcOfBorg build xidlehook

@ofborg ofborg bot requested a review from jD91mZM2 March 28, 2020 08:11
@Mic92 Mic92 merged commit b4567fb into NixOS:master Mar 28, 2020
@Mic92 Mic92 deleted the xidlehook branch March 28, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants