Add black formatting check to PR validation in CI; switch from Travis to Github Actions #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhipple
force-pushed
the
feature/formatting-ci
branch
from
d54f81d
to
e409f03
Compare
bhipple
commented
Mar 15, 2020
Having merged the format updates in NixOS#22, let's add it to pull request validation to ensure we don't backslide. Note that we could go one step further and add it to the `checkPhase` of the python package build, like [nixpkgs-review](https://github.com/Mic92/nixpkgs-review/blob/master/default.nix) does; however, doing so would break the build if someone tried to use the `nixops-aws` build on 19.09 vs. 20.03 vs. unstable, and since it's a CI/PR only concept this takes the more gentle approach of just adding it to Travis.
bhipple
force-pushed
the
feature/formatting-ci
branch
from
e409f03
to
9a43c90
Compare
adisbladis
approved these changes
Mar 15, 2020
bhipple
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having merged the format updates in #22,
let's add it to pull request validation to ensure we don't backslide.
Note that we could go one step further and add it to the
checkPhaseof thepython package build, like nixpkgs-review
does; however, doing so would break the build if someone tried to use the
nixops-awsbuild on 19.09 vs. 20.03 vs. unstable, and since it's a CI/PR onlyconcept this takes the more gentle approach of just adding it to Travis.