Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/security/b3sum: fix cargo hash #82515

Merged
merged 1 commit into from Mar 27, 2020
Merged

tools/security/b3sum: fix cargo hash #82515

merged 1 commit into from Mar 27, 2020

Conversation

Xe
Copy link
Contributor

@Xe Xe commented Mar 14, 2020 •
edited

Motivation for this change

Fixes b3sum for NixOS 20.03 #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz March 14, 2020 00:22
@alyssais
Copy link
Member

Do we know why the hash changed?

@bhipple
Copy link
Contributor

bhipple commented Mar 14, 2020

I've verified that b3sum is OK on master; is there a way to get the old package from the 20.03 branch (binary cache maybe?) and diff against what you have here? I'd be curious what happened, and why it doesn't impact master.

@KamilaBorowska
Copy link
Member

KamilaBorowska commented Mar 15, 2020 •
edited

That's... weird, and really suspicious. I would look into why the hash did change, because I don't think that should have happened.

@bhipple
Copy link
Contributor

bhipple commented Mar 27, 2020

It'd be nice if someone could get the old FOD off a binary cache somewhere and diff it to see what actually happened, but in the meantime it's correct on master and this backport fixes the bad build on 20.03 for ZHF, so worth merging.

@bhipple bhipple merged commit 834ad82 into NixOS:release-20.03 Mar 27, 2020
@Xe Xe deleted the fix-b3sum branch March 27, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xe @alyssais @bhipple @KamilaBorowska