Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: override cl-ppcre for next-browser to version bump #82632

Closed
wants to merge 1 commit into from
Closed

next: override cl-ppcre for next-browser to version bump #82632

wants to merge 1 commit into from

Conversation

bqv
Copy link
Contributor

@bqv bqv commented Mar 15, 2020

Motivation for this change

See #82631

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nlewo March 15, 2020 05:11
@bqv
Copy link
Contributor Author

bqv commented Mar 15, 2020

Hang on, this doesn't work, seems this fix only overrides the immediate dependency but transitive ones remain old. Will rework

@bqv bqv closed this Mar 15, 2020
@bqv
Copy link
Contributor Author

bqv commented Mar 15, 2020

@nlewo @ysengrimm Hey, how do I update quicklisp, I've amended the overrides file in my branch (pushed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bqv