Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 7c3f3e9c51f5
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 115c78c9b399
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 15, 2020

  1. mariadb: remove withoutClient 

    When used as a global override, it breaks most of the options in the
mysql module, such as ensureDatabases, ensureUsers, initialDatabases,
initialScript.

We could use `.client` there, but if the reasoning behind this was
closure size reduction, we now end up with the same (or a bigger)
runtime closure and more complexity.

Apart from the options exposed by the mysql module, the client is also
likely to be required for local backups or DBA tasks anyways.

Instead of dealing with all the increased complexity of this for no
arguable benefit, let's just remove the `withoutClient` argument.
Storage space on mysql servers shouldn't be that much of an issue.

Closes #82428.
    @flokli
    flokli committed Mar 15, 2020
    Copy the full SHA
    4b8d66a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #82649 from flokli/mariadb-remove-without-client 

    mariadb: remove withoutClient
    @flokli
    flokli committed Mar 15, 2020
    Copy the full SHA
    115c78c View commit details
    Browse the repository at this point in the history