aucatctl: init at 0.1 #82556
Merged
aucatctl: init at 0.1 #82556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows those who use sndiod to adjust the volume of audio programs.
alyssais
reviewed
Mar 14, 2020
|
Thank you for reviewing this! I went ahead and applied your suggestions related to the operating system support. You are correct, I made a mistake in the prePatch being only for Linux. The new commit should address this, with |
alyssais
requested changes
Mar 16, 2020
| }; | ||
|
|
||
| buildInputs = [ sndio ] | ||
| ++ stdenv.lib.optional (!stdenv.isDarwin && !stdenv.hostPlatform.isBSD) |
There was a problem hiding this comment.
Oh, is there no stdenv.isBSD? in that case, this should be
Suggested change
| ++ stdenv.lib.optional (!stdenv.isDarwin && !stdenv.hostPlatform.isBSD) | |
| ++ stdenv.lib.optional (!stdenv.isDarwin && !stdenv.targetPlatform.isBSD) |
| preBuild = '' | ||
| makeFlagsArray+=("PREFIX=$out") | ||
| '' + stdenv.lib.optionalString | ||
| (!stdenv.isDarwin && !stdenv.hostPlatform.isBSD) '' |
|
@GrahamcOfBorg build aucatctl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allows those who use sndiod to adjust the volume of audio programs.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)