Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncspot: enable MPRIS by default #82558

Merged
merged 1 commit into from Apr 2, 2020
Merged

ncspot: enable MPRIS by default #82558

merged 1 commit into from Apr 2, 2020

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Mar 14, 2020

Motivation for this change

MPRIS is what allows controlling media players with global keybinds, start-stop, next, previous, etc.
It's enabled by default upstream, and should be here too. If someone wants to avoid dbus for some reason, they can disable it.

I chose withMPRIS instead of withDbus, because it's not immediately clear what someone would want dbus for, and upstream called the feature mpris.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @marsam

@ofborg ofborg bot requested a review from marsam March 14, 2020 08:54
@tilpner
Copy link
Member Author

tilpner commented Apr 1, 2020

@marsam Could you comment on this change?

@marsam
Copy link
Contributor

marsam commented Apr 2, 2020 •
edited

Sorry for the delay. LGTM, I've disabled the withMPRIS on darwin, because dbus is rarely used there, I hope you don't mind

@marsam marsam merged commit aa8bd52 into NixOS:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tilpner @marsam