secp256k1-haskell: fix pkgconfig-depends #444
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@jtobin Thanks for following up here. I think the correct place to make this change is in this list: cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/Name.hs Lines 16 to 31 in 722a377 This is the list that maps pkg-config dependencies to their respective package name in nixpkgs. Adding the correct mapping for |
Unbreaks secp256k1-haskell and other Haskell packages that depend on it.
jtobin
force-pushed
the
secp256k1-haskell
branch
from
aeb27f1 to
ca1fb58
Compare
|
Nice catch, thanks. Done, and confirmed as working via the same test mentioned in OP. |
|
(Oh, Dennis! Hi! We chatted in late 2018. Hope all's well! 😄) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is currently broken in nixpkgs; overriding 'libsecp256k1' with 'secp256k1' in pkgconfig-depends unbreaks it.
I've tested that this works as expected by building
cabal2nix, callingcabal2nix cabal://secp256k1-haskell-0.1.8, and runningnix-buildon the (appropriately-called) result.See NixOS/nixpkgs#82562.