Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas: disable optimisation pending fix #82587

Merged
merged 1 commit into from Mar 14, 2020

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Mar 14, 2020

See OpenMathLib/OpenBLAS#2496

Motivation for this change

R is broken (test failure) on aarch64, due to a bug in OpenBLAS (Other packages may also be broken, they just don't have tests that show the breakage). The bug seems to be in code optimised for a specific platform, so reverting to the generic C implementation seems sensible until an upstream fix is available.

ZHF #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

@GrahamcOfBorg build r

@alyssais
Copy link
Member

@GrahamcOfBorg build R

@alyssais alyssais merged commit c6c7536 into NixOS:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants