New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python.pkgs.{gitdb,GitPython}: update #82589
Conversation
From the linked issue:
Yes, let's make this change. |
656be90
to
a0f1e9e
Compare
To be precise, the split happened in 2015 but the merge back only happened recently. So it may very well be that people are using It wouldn't be difficult to fix though, so I don't see much point in backwards compatibility here. I noticed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[31 built (2 failed), 778 copied (2732.6 MiB), 505.1 MiB DL]
error: build of '/nix/store/mqs5ws3sb5akiigcpaklxxdw8rrqjhzj-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82589
2 package failed to build:
dvc-with-remotes python38Packages.apache-airflow
27 package built:
apache-airflow dvc fdroidserver fluidasserts git-repo-updater git-up mlflow-server opentimestamps-client python37Packages.GitPython python37Packages.bandit python37Packages.cccolutils python37Packages.git-sweep python37Packages.gitdb python37Packages.mlflow python37Packages.nbdime python37Packages.opentimestamps python37Packages.stytra python38Packages.GitPython python38Packages.bandit python38Packages.cccolutils python38Packages.git-sweep python38Packages.gitdb python38Packages.mlflow python38Packages.nbdime python38Packages.opentimestamps python38Packages.stytra snakemake
slightly concerned about the removals. Might be nice to do a
gitdb2 = throw "gitdb2 has been deprecated, use gitdb instead."; # added 2020-MM-DD
The two are now the same: gitpython-developers/gitdb#59
They were recently merged back together and smmap is the canonical version: gitpython-developers/smmap#44
a0f1e9e
to
e04fe98
Compare
Yeah, that might be helpful. How about this? |
Motivation for this change
I had issues with the outdated
GitPython
and thegitdb
update is a dependency.@FRidh do you think dropping
gitdb2
is the right thing to do, given the merge and that gitdb is the canonical version?Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)