Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom 404 page #347

Merged
merged 1 commit into from Mar 16, 2020
Merged

Add custom 404 page #347

merged 1 commit into from Mar 16, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Mar 15, 2020

Closes #343

image

This works on top of automatic handling by Netlify:

You can set up a custom 404 page for all paths that don't resolve to a static file. This doesn't require any redirect rules. If you add a 404.html page to your site, it will be picked up and displayed automatically for any failed paths.


I believe the small script to print the URL in the text body is important UX-wise. This will make end-user screenshots or text copy/paste more useful. Sure, it won't work for users who disable scripts, but that's their own decision. The text has been conceived with progressive enhancement in mind.

This is better than:

image

@grahamc grahamc merged commit d8d419f into NixOS:master Mar 16, 2020
@samueldr samueldr deleted the feature/404 branch March 16, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prep a customized 404
2 participants