Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quicklisp: 2017-03-06 -> 2019-02-16 and lispPackages: update distinfo #82687

Merged
merged 2 commits into from Mar 15, 2020
Merged

quicklisp: 2017-03-06 -> 2019-02-16 and lispPackages: update distinfo #82687

merged 2 commits into from Mar 15, 2020

Conversation

claudiiii
Copy link
Contributor

Motivation for this change

Updated quicklisp and the distinfo.txt to the newest versions.
I hope it's ok to do this both in one pr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@claudiiii claudiiii mentioned this pull request Mar 15, 2020
Closed
bqv
bqv approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@bqv bqv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely fine for me, tried to test with nixpkgs-review but it failed. Tested instead by building all non-broken non-lisp-packages changed that are affected by this (apparently only pkgs.next anyway), and that at least works fine. 👍

@7c6f434c
Copy link
Member

@GrahamcOfBorg build lispPackages.iolib lispPackages.stumpwm

@7c6f434c 7c6f434c merged commit deb665d into NixOS:master Mar 15, 2020
@claudiiii claudiiii deleted the update-quicklisp branch February 2, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bqv bqv bqv approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@claudiiii @7c6f434c @bqv