autoflake: remove unused stdlib imports #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs `autoflake --in-place **/*.py` to remove unused std library imports. Note that there are quite a few unused non-stdlib imports as well, but removing those is slightly riskier as they could have import side-effects, so they should be done in a second pass with a reduced diff. https://pypi.org/project/autoflake/
|
CC @AmineChikhaoui @grahamc @adisbladis check it out, CI on pull requests is working! And the first build failed due to |
|
Yay! |
bhipple
added a commit
to bhipple/nixops-aws
that referenced
this pull request
Mar 22, 2020
Follow-up to NixOS#28, this removes non-stdlib imports with: autoflake --in-place --remove-all-unused-imports **/*.py except for the API `__init__.py` file.
bhipple
added a commit
to bhipple/nixops-aws
that referenced
this pull request
Mar 22, 2020
Follow-up to NixOS#28, this removes non-stdlib imports with: autoflake --in-place --remove-all-unused-imports **/*.py except for the API `__init__.py` file. No manual or functional changes, just cleanup.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs
autoflake --in-place **/*.pyto remove unused std library imports.Note that there are quite a few unused non-stdlib imports as well, but removing
those is slightly riskier as they could have import side-effects, so they should
be done in a second pass with a reduced diff.
https://pypi.org/project/autoflake/