Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmt: init at 1.17 #82683

Merged
merged 1 commit into from Mar 16, 2020
Merged

cmt: init at 1.17 #82683

merged 1 commit into from Mar 16, 2020

Conversation

sjfloat
Copy link
Contributor

@sjfloat sjfloat commented Mar 15, 2020 •
edited

Motivation for this change

Introduction of new package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (New pkg -- no dependents)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sjfloat
Copy link
Contributor Author

sjfloat commented Mar 16, 2020 •
edited

@jonringer Does anyone know why I can't request review on this? It's greyed out.

jonringer
jonringer reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there supposed to be headers? all that's exported is a .so

$ tree ./results/cmt
./results/cmt
└── lib
    └── ladspa
        └── cmt.so

pkgs/applications/audio/cmt/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

@jonringer Does anyone know why I can't request review on this? It's greyed out.

no idea, but I've noticed github having issues for a while

@sjfloat
Copy link
Contributor Author

sjfloat commented Mar 16, 2020

@jonringer Does anyone know why I can't request review on this? It's greyed out.

no idea, but I've noticed github having issues for a while

Thanks again!

@sjfloat
Copy link
Contributor Author

sjfloat commented Mar 16, 2020

is there supposed to be headers? all that's exported is a .so

$ tree ./results/cmt
./results/cmt
└── lib
    └── ladspa
        └── cmt.so

Excellent question! But no, these are plugins. Nothing is built against them.

@sjfloat sjfloat requested a review from jonringer March 16, 2020 18:01
jonringer
jonringer reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind squashing the changes commit into the original commit. Otherwise LGTM

@sjfloat
Copy link
Contributor Author

sjfloat commented Mar 16, 2020

do you mind squashing the changes commit into the original commit. Otherwise LGTM

Not at all!

jonringer
jonringer approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82683
1 package built:
cmt

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-82683-1]$ nix path-info -Sh ./results/cmt
/nix/store/kdvk7lwcdgcj2k03djjh1w7im5694768-cmt	  37.5M

@jonringer
Copy link
Contributor

@GrahamcOfBorg build cmt

@jonringer jonringer merged commit 2ff00c4 into NixOS:master Mar 16, 2020
@sjfloat sjfloat deleted the cmt branch March 16, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjfloat @jonringer