Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfxr-qt: 1.2.0 -> 1.3.0 #82656

Merged
merged 1 commit into from Mar 27, 2020
Merged

sfxr-qt: 1.2.0 -> 1.3.0 #82656

merged 1 commit into from Mar 27, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Mar 15, 2020

Motivation for this change

New release. I also cleaned up some stuff.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the package builds, executable is wrapped and running.

@rnhmjoj rnhmjoj merged commit cccdf3d into NixOS:master Mar 27, 2020
@fgaz fgaz deleted the sfxr-qt/1.3.0 branch June 16, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants