Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire-desktop: linux 3.12.2916 -> 3.15.2922, mac 3.12.3490 -> 3.15.3621 #82664

Merged
merged 3 commits into from Mar 27, 2020

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Mar 15, 2020

Motivation for this change

Bump both mac and linux version of "wire-desktop".
This PR would supersede #82236, which lacked the mac version bump and used an unofficial version number.

Should we switch to SRI hashes?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arianvp
Copy link
Member

arianvp commented Mar 15, 2020

LGTM. We can close the previous PR.

@turboMaCk
Copy link
Member

Looks good! closing old PR.

@toonn
Copy link
Contributor Author

toonn commented Mar 26, 2020

They made another linux release so this PR has two bumps for linux now. Half expecting another macOS release as well.

@turboMaCk
Copy link
Member

turboMaCk commented Mar 26, 2020

well that means that now we're in same situation as with my original Linux update PR where we decided to wait for update for both platforms.

@Kiwi
Copy link
Member

Kiwi commented Mar 26, 2020

for what little it matters now i did test the linux version on nixos briefly and minimally last night and didn't notice anything bad.

@arianvp
Copy link
Member

arianvp commented Mar 26, 2020

The MacOS release will probably be up tomorrow. Sorry that these things do not always perfectly align; because signing and release process differs per platform

@arianvp
Copy link
Member

arianvp commented Mar 27, 2020

MacOS release is now out.

I'll evaluate if I can maybe make a bot that triggers a PR to nixpkgs when our internal CI systems trigger; this means these kind of updates will be less manual in the future.

@toonn
Copy link
Contributor Author

toonn commented Mar 27, 2020

Can't find it on github yet.

Not that these bumps are usually trivial to automate indeed but the current bump for macOS required changing the source URL. Just something to keep in mind.

@flokli flokli mentioned this pull request Mar 27, 2020
10 tasks
@flokli flokli merged commit 7281887 into NixOS:master Mar 27, 2020
@flokli
Copy link
Contributor

flokli commented Mar 27, 2020

backported to 20.03 in 7730ed9 cf77a5f 97d3d1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants