New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire-desktop: linux 3.12.2916 -> 3.15.2922, mac 3.12.3490 -> 3.15.3621 #82664
Conversation
0482270
to
39b3969
Compare
LGTM. We can close the previous PR. |
Looks good! closing old PR. |
They made another linux release so this PR has two bumps for linux now. Half expecting another macOS release as well. |
well that means that now we're in same situation as with my original Linux update PR where we decided to wait for update for both platforms. |
for what little it matters now i did test the linux version on nixos briefly and minimally last night and didn't notice anything bad. |
The MacOS release will probably be up tomorrow. Sorry that these things do not always perfectly align; because signing and release process differs per platform |
MacOS release is now out. I'll evaluate if I can maybe make a bot that triggers a PR to nixpkgs when our internal CI systems trigger; this means these kind of updates will be less manual in the future. |
Can't find it on github yet. Not that these bumps are usually trivial to automate indeed but the current bump for macOS required changing the source URL. Just something to keep in mind. |
Motivation for this change
Bump both mac and linux version of "wire-desktop".
This PR would supersede #82236, which lacked the mac version bump and used an unofficial version number.
Should we switch to SRI hashes?
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)