Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stubby: enable Type=notify for better startup sequencing #82636

Merged
merged 2 commits into from Mar 16, 2020
Merged

stubby: enable Type=notify for better startup sequencing #82636

merged 2 commits into from Mar 16, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 15, 2020

Motivation for this change

Improves startup sequencing by using systemd Type=notify to only consider the stubby DNS resolver as available when it is ready to serve queries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
stubby: build with libsystemd support
2d40c75 
This was added in v0.3.0 and allows notifying service readiness.
@delroth
nixos/stubby: set Type=notify on the systemd service
f5165f0 
Fixes some dependency ordering problems at boot time with services that
require DNS. Without Type=notify these services might be started before
stubby was ready to accept DNS requests.
@ofborg ofborg bot requested a review from ehmry March 15, 2020 06:43
@ehmry ehmry merged commit b8ef228 into NixOS:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delroth @ehmry