bitwig-studio3: 3.1.2 -> 3.1.3 #82635
Conversation
| url = "https://downloads.bitwig.com/stable/${version}/bitwig-studio-${version}.deb"; | ||
| sha256 = "07djn52lz43ls6fa4k1ncz3m1nc5zv2j93hwyavnr66r0hlqy7l9"; | ||
| url = | ||
| "https://downloads.bitwig.com/stable/${version}/bitwig-studio-${version}.deb"; |
There was a problem hiding this comment.
I'd keep this on one line.
There was a problem hiding this comment.
Can do, but this is the output of nixfmt I don't format my files manually.
| @@ -1,17 +1,16 @@ | |||
| { fetchurl, bitwig-studio1, pulseaudio, xorg }: | |||
| { stdenv, fetchurl, bitwig-studio2, xorg, ... }: | |||
There was a problem hiding this comment.
Why the swap to ... var args? And it doesn't look like stdenv is used here?
There was a problem hiding this comment.
true, will change that.
|
|
||
| bitwig-studio1.overrideAttrs (oldAttrs: rec { | ||
| bitwig-studio2.overrideAttrs (oldAttrs: rec { |
There was a problem hiding this comment.
Usually, when packaging multiple versions, we factor out into something like a common.nix and then have the specific versions pass in the src and version themselves, rather than chaining them on top of each other with overrides. Here, if we change something idiosyncratic to the base package, we'd rebuild them all.
Take a look at boost for an example.
There was a problem hiding this comment.
Makes sense. Will have a look at it, but the old versions won't be updated anymore. At least that is what the business model of bitwig says.
|
Closed in favor of #89101 |
Motivation for this change
version bump
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)