Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: Clean up php derivation #82667

Merged
merged 3 commits into from Mar 15, 2020
Merged

php: Clean up php derivation #82667

merged 3 commits into from Mar 15, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 15, 2020

Motivation for this change

I'm on this mission to clean up the PHP package, so I have done #82348 as a starting point to get a more modular setup.

This PR doesn't actually change the result of any version of PHP that we support. It's just a clean up to make the file easier to work with.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

etu added 2 commits March 15, 2020 10:27
@etu
php: Re-indent main derivation
da3384a
@etu
php: remove unsupported options
6100ac4 
 - mcrypt was removed in 7.2
 - mhash was integrated into hash in 7.0
@adisbladis adisbladis merged commit d828748 into NixOS:master Mar 15, 2020
@etu etu deleted the clean-up-php-derivation branch March 15, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @adisbladis