Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cheesecutter: init at unstable-2019-12-06 #82666

Merged
merged 2 commits into from Mar 27, 2020

Conversation

OPNA2608
Copy link
Contributor

Motivation for this change

Packaging more FOSS chiptune tracker, see #81815.

Last proper releases are blocked by the lack of GDC in nixpkgs (usage of legacy D syntax that ldc and dmd refuse to accept). Fortunately, master actually compiles under non-GDC compilers, though the alternative stereo version that the releases are exposing via tags is lacking behind in commits.

If the stereo version is desired as well, I can look into that though.

I patched out references to a function that uses Dlang's __DATE__, which would display the date of the build in the top-left corner of the application (i.e., "Mar 15 2020"). My thought behind that was to reduce differences between rebuilds without version updates, though I can drop the patch if you think it's not that big of a deal.

Also packaged the ACME Cross-Assembler, as it's a build-time dependency of the tool that assembles the module data into a C64 file. I haven't extensively tested it, but the assembler itself works fine in CheeseCutter's Makefile, and an assembled SID file sounds okay as well.

cc @fgaz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer patching the elf, rather than wrapping, as it composes better if addition wrapping is needed else where

pkgs/applications/audio/cheesecutter/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/cheesecutter/default.nix Outdated Show resolved Hide resolved
@OPNA2608
Copy link
Contributor Author

Addressed, thanks.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
launches fine

[5 built, 10 copied (333.9 MiB), 60.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82666
2 package built:
acme cheesecutter

@jonringer jonringer merged commit 81d0e3d into NixOS:master Mar 27, 2020
@OPNA2608 OPNA2608 deleted the package-ccutter branch September 27, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants