Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: A company goal type will open the company overview window when clicked #8033

Merged
merged 1 commit into from Mar 22, 2020
Merged

Change: A company goal type will open the company overview window when clicked #8033

merged 1 commit into from Mar 22, 2020

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Mar 8, 2020 •
edited

https://docs.openttd.org/gs-api/classGSGoal.html

I noticed goals of type GT_COMPANY were "unclickable" even when I set a proper company.
GSGoal.New(GSCompany.COMPANY_INVALID, "random text", GSGoal.GT_COMPANY, GSCompany.COMPANY_FIRST);

glx22
glx22 approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct, but commit message needs to be rewritten on merge, it's definitely too long

@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Mar 14, 2020
@glx22 glx22 merged commit 3e680c5 into OpenTTD:master Mar 22, 2020
@SamuXarick SamuXarick deleted the company-goal-type branch March 22, 2020 15:01
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Mar 30, 2020
@SamuXarick @LordAro
Change: Open company window when clicking on a company goal (OpenTTD#…
e2718b3 
…8033)
LordAro pushed a commit that referenced this pull request Mar 31, 2020
@SamuXarick @LordAro
Change: Open company window when clicking on a company goal (#8033)
18ad0fa
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 31, 2020
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
@SamuXarick @douiwby
Change: Open company window when clicking on a company goal (OpenTTD#…
5682212 
…8033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamuXarick @glx22 @LordAro