Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 24219f69a367
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7b3802dfd11b
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 14, 2020

  1. sentencepiece: split into multiple outputs, optional gperftools 

    I am using sentencepiece in a downstream application where I want to
minimize the resulting closures. This commit makes changes to make
sentencepiece a leaner dependency:

- Split the outputs, so that the binaries/headers do not end up in the
  transitive closure in a library dependency.

- Add the `withGPerfTools` option, which is enabled by default, to
  make it possible to disable the gperftools dependency. According to
  the sentencepiece README, this dependency gives a 10-40% performance
  improvement. But in many cases this is overshadowed by the neural
  networks that use piece identifiers as input anyway.
    @danieldk
    danieldk authored and Jon committed Mar 14, 2020
    Copy the full SHA
    27d0c5a View commit details
    Browse the repository at this point in the history

  2. sentencepiece: add myself as a maintainer

    @danieldk
    danieldk authored and Jon committed Mar 14, 2020
    Copy the full SHA
    7b3802d View commit details
    Browse the repository at this point in the history