Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CryptSSLeay: 0.72 -> 0.73_06 #82644

Closed
wants to merge 1 commit into from
Closed

perlPackages.CryptSSLeay: 0.72 -> 0.73_06 #82644

wants to merge 1 commit into from

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

ZHF: #80379

This is a development version, but even Debian uses development version, so it's probably fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build perl528Packages.CryptSSLeay perl530Packages.CryptSSLeay

mmilata
mmilata approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but I'm no Perl nor crypto person. The rt build failure seems unrelated.

Result of nixpkgs-review pr 82644 1

1 package failed to build:
  • rt
11 package built:
  • debian-devscripts
  • ikiwiki
  • longview
  • perl528Packages.BytesRandomSecure
  • perl528Packages.CryptRandomSeed
  • perl528Packages.CryptRandomTESHA2
  • perl528Packages.CryptSSLeay
  • perl530Packages.BytesRandomSecure
  • perl530Packages.CryptRandomSeed
  • perl530Packages.CryptRandomTESHA2
  • perl530Packages.CryptSSLeay

JeffLabonte
JeffLabonte suggested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had an error while it built.

builder for '/nix/store/kx96qdk5rwd2mavqhp8yrybapaiimq7p-rt-4.4.4.drv' failed with exit code 2; last 10 log lines:
     rt group (1000) ...MISSING
     web group (1000) ...MISSING
    web owner (1000) ...MISSING
  CLI missing dependencies:
  CORE missing dependencies:
  GD missing dependencies:
  GPG missing dependencies:
  MAILGATE missing dependencies:
  SOME DEPENDENCIES WERE MISSING.
  SQLITE missing dependencies:
cannot build derivation '/nix/store/smbnqd6ybi4sdlyzkz6vb9n72sh0xr7w-env.drv': 1 dependencies couldn't be built
[6 built (1 failed)]
error: build of '/nix/store/smbnqd6ybi4sdlyzkz6vb9n72sh0xr7w-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82644
1 package failed to build:
rt

11 package built:
debian-devscripts ikiwiki longview perl528Packages.BytesRandomSecure perl528Packages.CryptRandomSeed perl528Packages.CryptRandomTESHA2 perl528Packages.CryptSSLeay perl530Packages.BytesRandomSecure perl530Packages.CryptRandomSeed perl530Packages.CryptRandomTESHA2 perl530Packages.CryptSSLeay

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Mar 18, 2020 •
edited

@JeffLabonte I'm aware of rt error, I want to say it's out of scope for this pull request. rt doesn't even have a dependency on CryptSSLeay in its current version, this is a leftover from an older version, see bestpractical/rt@c567d14.

@KamilaBorowska
Copy link
Member Author

rt handled in #82823, let's not block this ticket over rt.

@mmilata
Copy link
Member

mmilata commented Mar 19, 2020

Oh, there's already #81438 for this.

@KamilaBorowska
Copy link
Member Author

Oh, so it is.

jonringer
jonringer approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[16 built (1 failed), 216 copied (65.5 MiB), 17.1 MiB DL]
error: build of '/nix/store/smbnqd6ybi4sdlyzkz6vb9n72sh0xr7w-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82644
1 package failed to build:
rt

11 package built:
debian-devscripts ikiwiki longview perl528Packages.BytesRandomSecure perl528Packages.CryptRandomSeed perl528Packages.CryptRandomTESHA2 perl528Packages.CryptSSLeay perl530Packages.BytesRandomSecure perl530Packages.CryptRandomSeed perl530Packages.CryptRandomTESHA2 perl530Packages.CryptSSLeay

rt broken on master

@jonringer
Copy link
Contributor

I will prefer earlier PR, since I "failed" to address his/her PR earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@jonringer jonringer jonringer approved these changes

@JeffLabonte JeffLabonte JeffLabonte approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @mmilata @jonringer @JeffLabonte