Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retdec: fix build #82647

Merged
merged 1 commit into from Mar 15, 2020
Merged

retdec: fix build #82647

merged 1 commit into from Mar 15, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 15, 2020 •
edited

Motivation for this change

The build was broken by the gcc9 update. Pinning to gcc8 for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
retdec: fix build
e5642d4 
The build was broken by the gcc9 update. Pinning to gcc8 for now.
@ofborg ofborg bot requested a review from dtzWill March 15, 2020 11:05
@timokau
Copy link
Member Author

timokau commented Mar 15, 2020

A user notified us of this failure via email. Here's the backport: #82648

@timokau timokau mentioned this pull request Mar 15, 2020
Merged
10 tasks
@timokau timokau merged commit 2e68526 into NixOS:master Mar 15, 2020
@timokau timokau deleted the retdec-fix branch March 15, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau