Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with flags found in game #2495

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Mar 14, 2020

No description provided.

foreach (String value in individual_flag.GetValues()) {
Interface.SetFlag(individual_flag.name, value);
ConfigNode flags =
GameDatabase.Instance.GetAtMostOneNode(principia_flags_);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

ConfigNode.ValueList flags = GameDatabase.Instance.GetAtMostOneNode(principia_flags_)?.values
if (flags != null) {
  foreach (ConfigNode.Value flag in flags) {
    // etc.

Unless by individual_flag we mean "as opposed to flag in a subnode" and have dreams of more-structured flags later on?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@eggrobin eggrobin added the LGTM label Mar 14, 2020
@pleroy pleroy merged commit 82fd374 into mockingbirdnest:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants