Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptpad: 3.0.1 -> 3.13.0 #82602

Merged
merged 1 commit into from Mar 14, 2020
Merged

cryptpad: 3.0.1 -> 3.13.0 #82602

merged 1 commit into from Mar 14, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Mar 14, 2020 •
edited

Motivation for this change

Fixes #82598

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member Author

zimbatm commented Mar 14, 2020

@symphorien do you mind testing this PR? I did the update for you but haven't really tested things out.

On top of calling the generate.sh script, the update process involves forking the cryptpad repo, calling bower2nix, then patching a few of the entries manually because the process isn't very precise. I was hoping that they would move away from bower since it's unmaintained and not very secure.

@symphorien
Copy link
Member

I deployed an instance of cryptpad based on this PR and it seems to work fine. Thanks!

@alyssais
Copy link
Member

Commit message is missing the p

@zimbatm zimbatm changed the title cryptad: 3.0.1 -> 3.13.0 cryptpad: 3.0.1 -> 3.13.0 Mar 14, 2020
@zimbatm zimbatm merged commit b6fe12b into NixOS:master Mar 14, 2020
@zimbatm zimbatm deleted the cryptpad-3.13.0 branch March 14, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cryptpad is outdated
3 participants
@zimbatm @symphorien @alyssais