Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upate buildDhallPackage to use default version of Dhall #85008

Merged
merged 1 commit into from Apr 11, 2020
Merged

Upate buildDhallPackage to use default version of Dhall #85008

merged 1 commit into from Apr 11, 2020

Conversation

Gabriella439
Copy link
Contributor

Now that the default version is sufficiently new we don't need to
pin the Dhall version any longer in buildDhallPackage

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gabriella439
Upate buildDhallPackage to use default version of Dhall
9f2dd99 
Now that the default version is sufficiently new we don't need to
pin the Dhall version any longer in `buildDhallPackage`
@domenkozar domenkozar merged commit fa613bc into NixOS:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gabriella439 @domenkozar