Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: 1.19.1.2630-72c16a276 -> 1.19.1.2645-ccb6eb67e #84905

Merged
merged 1 commit into from Apr 10, 2020
Merged

plex: 1.19.1.2630-72c16a276 -> 1.19.1.2645-ccb6eb67e #84905

merged 1 commit into from Apr 10, 2020

Conversation

endocrimes
Copy link
Member

Motivation for this change

Plex's UI is very pushy about new updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • (NA) Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endocrimes endocrimes changed the title plex: 1.19.1.2630-72c16a276 -> 1.19.1.2630-72c16a276 plex: 1.19.1.2630-72c16a276 -> 1.19.1.2645-ccb6eb67e Apr 10, 2020
@CloudArtAdmins
Copy link
Contributor

This worked for me.
Did some binaries testing.

@bhipple
Copy link
Contributor

bhipple commented Apr 10, 2020

Result of nixpkgs-review pr 84905 1

2 packages built:
- plex
- plexRaw

@bhipple bhipple merged commit 7e75024 into NixOS:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@colemickens colemickens Awaiting requested review from colemickens

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@Forkk Forkk Awaiting requested review from Forkk

@LnL7 LnL7 Awaiting requested review from LnL7

@pjones pjones Awaiting requested review from pjones

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endocrimes @CloudArtAdmins @bhipple