Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qpdf: 9.1.1 -> 10.0.0 #84972

Closed
wants to merge 1 commit into from
Closed

qpdf: 9.1.1 -> 10.0.0 #84972

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/qpdf/versions.

meta.description for qpdf is: "A C++ library and set of programs that inspect and manipulate the structure of PDF files"

meta.homepage for qpdf is: "http://qpdf.sourceforge.net/"

Updates performed:

  • Version update
  • Quoted meta.homepage for RFC 45
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

24 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cups-filters
ocrmypdf
python37Packages.pikepdf
python38Packages.pikepdf
qpdf
splix
system-config-printer

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/0wylqhh6pla8r84v2sg8mv87x7j0szx1-qpdf-10.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A qpdf https://github.com/r-ryantm/nixpkgs/archive/d773e6728a87c37817503ea62317bf11b7f3cb01.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0wylqhh6pla8r84v2sg8mv87x7j0szx1-qpdf-10.0.0
ls -la /nix/store/0wylqhh6pla8r84v2sg8mv87x7j0szx1-qpdf-10.0.0/bin

cc @abbradar for testing.

@ofborg ofborg bot requested a review from abbradar April 11, 2020 04:35
@CloudArtAdmins
Copy link
Contributor

This built and ran for me.

@teto
Copy link
Member

teto commented Apr 12, 2020

nixpkgs-review pr 84972 triggered a few errors

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/teto/.cache/nixpkgs-review/pr-84972/build.nix
note: keeping build directory '/tmp/nix-build-python3.8-pikepdf-1.10.2.drv-0'
builder for '/nix/store/gbxcpilr8agcz9fzlj8m45s7hwjx3mgr-python3.8-pikepdf-1.10.2.drv' failed with exit code 1; last 10 log lines:
      def test_minimum_qpdf_version():
          from pikepdf import _qpdf
      
  >       assert _qpdf.qpdf_version() >= '7.0.0'
  E       AssertionError: assert '10.0.0' >= '7.0.0'
  E        +  where '10.0.0' = <built-in method qpdf_version of PyCapsule object at 0x7ffff6e3e0c0>()
  E        +    where <built-in method qpdf_version of PyCapsule object at 0x7ffff6e3e0c0> = <module 'pikepdf._qpdf' from '/build/pikepdf-1.10.2/src/pikepdf/_qpdf.cpython-38-x86_64-linux-gnu.so'>.qpdf_version
  
  tests/test_sanity.py:27: AssertionError
  ================== 3 failed, 260 passed, 5 skipped in 20.08s ===================
note: keeping build directory '/tmp/nix-build-python3.7-pikepdf-1.10.2.drv-0'
builder for '/nix/store/jy20mqf4c9pci8d5lp6gl50x1d7nxnyn-python3.7-pikepdf-1.10.2.drv' failed with exit code 1; last 10 log lines:
      def test_minimum_qpdf_version():
          from pikepdf import _qpdf
      
  >       assert _qpdf.qpdf_version() >= '7.0.0'
  E       AssertionError: assert '10.0.0' >= '7.0.0'
  E        +  where '10.0.0' = <built-in method qpdf_version of PyCapsule object at 0x7fffe6d04d80>()
  E        +    where <built-in method qpdf_version of PyCapsule object at 0x7fffe6d04d80> = <module 'pikepdf._qpdf' from '/build/pikepdf-1.10.2/src/pikepdf/_qpdf.cpython-37m-x86_64-linux-gnu.so'>.qpdf_version
  
  tests/test_sanity.py:27: AssertionError
  ================== 3 failed, 260 passed, 5 skipped in 21.12s ===================
cannot build derivation '/nix/store/8z15b62wc5l1rzcfaxiaixlpsiyhhny3-ocrmypdf-9.6.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yjdrm75adpxnh0p0clpyc0vbsagglrig-env.drv': 3 dependencies couldn't be built
[7 built (2 failed), 84 copied (1181.5 MiB), 411.6 MiB DL]
error: build of '/nix/store/yjdrm75adpxnh0p0clpyc0vbsagglrig-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/84972
3 package failed to build:
ocrmypdf python37Packages.pikepdf python38Packages.pikepdf

4 package built:
cups-filters qpdf splix system-config-printer

@r-ryantm r-ryantm closed this Jun 11, 2020
@r-ryantm r-ryantm deleted the auto-update/qpdf branch June 11, 2020 04:56
@ryantm ryantm restored the auto-update/qpdf branch June 11, 2020 05:18
@ryantm ryantm reopened this Jun 11, 2020
@r-ryantm r-ryantm closed this Jun 14, 2020
@r-ryantm r-ryantm deleted the auto-update/qpdf branch June 14, 2020 03:31
@ryantm ryantm restored the auto-update/qpdf branch June 14, 2020 04:31
@ryantm ryantm reopened this Jun 14, 2020
@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the auto-update/qpdf branch July 1, 2020 04:40
@ryantm ryantm restored the auto-update/qpdf branch July 1, 2020 04:48
@ryantm ryantm reopened this Jul 1, 2020
@doronbehar
Copy link
Contributor

Closed in favor of #97752 . 10.0.1 fixed a certain regression which might have had something with those reverse deps failing to build.

@doronbehar doronbehar closed this Sep 11, 2020
@r-ryantm r-ryantm deleted the auto-update/qpdf branch September 24, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @CloudArtAdmins @teto @doronbehar @ryantm