Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: f19157dfa033
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: ab018f754bc9
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 10, 2020

  1. nixos/network-interfaces: assertion for DHCP on bridges 

    Assert that the user doesn't have a bridge configured while
networking.useDHCP is true. Due to new behaviour of dhcpcd [0], this
would result in the bridge not getting an address via DHCP, regardless
of wether it has networking.interfaces.<name?>.useDHCP set or not.

[0] https://roy.marples.name/archives/dhcpcd-discuss/0002621.html
    @erictapen
    erictapen committed Apr 10, 2020
    Copy the full SHA
    54ad186 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #84221 from erictapen/dhcpcd-error-on-bridges 

    [20.03] nixos/network-interfaces: Assert that bridges can get an address via DHCP
    @worldofpeace
    worldofpeace committed Apr 10, 2020
    Copy the full SHA
    ab018f7 View commit details
    Browse the repository at this point in the history