python3Packages.hydra-check: init at 1.1.1 #84917
Conversation
makefu
force-pushed
the
pkgs/hydra-check/init
branch
2 times, most recently
from
64165fa
to
63b4791
Compare
| repo = "hydra-check"; | ||
| rev = version; | ||
| sha256 = "1dmsscsib8ckp496gsfqxmq8d35zs71n99xmziq9iprvy7n5clq2"; | ||
|
|
There was a problem hiding this comment.
Nit: extra whitespace here
| flake8 hydracheck | ||
| echo -e "\x1b[32m## run mypy\x1b[0m" | ||
| mypy hydracheck | ||
| ''; |
There was a problem hiding this comment.
I would not do any of these checks inside the nix distribution: this will cause build failures when someone else goes to upgrade the version of black or flake8 or mypy, but these linting considerations are at the project src repo level, so they belong just in your CI for the project.
There was a problem hiding this comment.
i agree with black and flake8 but mypy seems to also check type hints. It might be useful to include it in case something changes with the next python version, no?
There was a problem hiding this comment.
I think that's fair. But mypy has also know to break some APIs, although I can't think of any in particular.
There was a problem hiding this comment.
or maybe it was that it became more strict. Either way, I've seen where a bump in mypy has caused failures
| ''; | ||
|
|
||
| meta = with lib;{ | ||
| homepage = https://github.com/nix-community/hydra-check; |
There was a problem hiding this comment.
| homepage = https://github.com/nix-community/hydra-check; | |
| homepage = "https://github.com/nix-community/hydra-check"; |
Quote for NixOS/rfcs#45
makefu
force-pushed
the
pkgs/hydra-check/init
branch
from
63b4791
to
b02211c
Compare
Motivation for this change
Add hydra-check into upstream nixpkgs. closes nix-community/hydra-check#6
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)