Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/release-notes/rl-2003.xml: add highlights #84930

Merged
merged 2 commits into from Apr 11, 2020
Merged

nixos/release-notes/rl-2003.xml: add highlights #84930

merged 2 commits into from Apr 11, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 10, 2020 •
edited

Fixes #79180.
Rendered

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/23

@flokli
Copy link
Contributor Author

flokli commented Apr 10, 2020

This targets 20.03 now. Do we want to forward-port this to master, or should the PR go to master?

@worldofpeace
Copy link
Contributor

This targets 20.03 now. Do we want to forward-port this to master, or should the PR go to master?

I feel like, with release notes that are for a certain release and it's already branched, the way to do it is to forward port to master.

worldofpeace
worldofpeace approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Ma27
Ma27 approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!

@flokli flokli merged commit 836e4b7 into NixOS:release-20.03 Apr 11, 2020
@flokli
Copy link
Contributor Author

flokli commented Apr 11, 2020

Forward-ported to master in 3bc5c8b and afd2e24.

@flokli flokli deleted the rl-2003-highlights branch April 11, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @nixos-discourse @worldofpeace @Ma27