New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron: fix wrapGAppsHook usage #84981
Conversation
This reverts commit fe6addb.
a3b1c62
to
96f52cb
Compare
Please review and test, I have very little idea of whether the change is correct. However, I tried that applying the first commit breaks riot-desktop (opening a native file dialog will crash) and applying the second commit fixes it again. @worldofpeace is that what you mean by "It needs to be rewritten in whatever fashion that the |
Result of 1 package marked as broken and skipped:
11 package built:
|
👍 I've tried the file open dialog (through "upload file") in the resulting |
Here's the wrapper content
it has correct entries so this is wrapped correctly 👍 |
Yep, you've done this correctly. |
Motivation for this change
Fixes #84913 by:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)