Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nixos-20.03] pingus: 0.7.6 -> unstable #84918

Merged
merged 2 commits into from Apr 11, 2020
Merged

[nixos-20.03] pingus: 0.7.6 -> unstable #84918

merged 2 commits into from Apr 11, 2020

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Apr 10, 2020

Motivation for this change

Backport #83706 to fix pingus in nixos-20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c April 10, 2020 17:25
@aanderse
Copy link
Member

So does pingus have music working again? See #80817.

aanderse
aanderse requested changes Apr 10, 2020
View reviewed changes
pkgs/games/pingus/default.nix Outdated Show resolved Hide resolved
@woffs
Copy link
Contributor Author

woffs commented Apr 10, 2020

So does pingus have music working again? See #80817.

music works. pingus did not even compile before (boost related failure)

@woffs woffs mentioned this pull request Apr 10, 2020
Merged
10 tasks
@7c6f434c 7c6f434c merged commit 4528f9d into NixOS:release-20.03 Apr 11, 2020
@AleXoundOS AleXoundOS mentioned this pull request Nov 15, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woffs @aanderse @7c6f434c