Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freerdp: 2.0.0-rc4 -> 2.0.0 #84919

Closed
wants to merge 1 commit into from
Closed

freerdp: 2.0.0-rc4 -> 2.0.0 #84919

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 10, 2020 •
edited

Motivation for this change

Upstream version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Apr 10, 2020 •
edited

This is a duplicate of #84885, which got in first; mind hashing out any diffs with them?

@bhipple bhipple closed this Apr 10, 2020
@ofborg ofborg bot requested a review from peterhoeg April 10, 2020 17:27
@prusnak prusnak deleted the freerdp branch April 10, 2020 17:28
@peterhoeg
Copy link
Member

Ohh, I like that we can run the tests again. @prusnak, do you mind prepping a new PR with that change?

@prusnak prusnak restored the freerdp branch April 11, 2020 18:32
@prusnak prusnak deleted the freerdp branch April 11, 2020 18:33
@prusnak
Copy link
Member Author

prusnak commented Apr 11, 2020

@peterhoeg #85020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @bhipple @peterhoeg