ocrfeeder: init at 0.8.3 #84939
ocrfeeder: init at 0.8.3 #84939
Conversation
doronbehar
force-pushed
the
package-ocrfeeder
branch
from
c55f70c
to
d54eedf
Compare
ofborg
bot
added
the
6.topic: GNOME
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
It'd be still nice to have, though another stale PR is a dependency for this one. |
stale
bot
removed
the
2.status: stale
doronbehar
force-pushed
the
package-ocrfeeder
branch
from
d54eedf
to
48f24f1
Compare
doronbehar
force-pushed
the
package-ocrfeeder
branch
from
48f24f1
to
54f6723
Compare
doronbehar
force-pushed
the
package-ocrfeeder
branch
from
54f6723
to
015e3b5
Compare
doronbehar
force-pushed
the
package-ocrfeeder
branch
from
015e3b5
to
cc7ce76
Compare
ofborg
bot
removed
the
6.topic: GNOME
|
Result of 4 packages built:
|
There was a problem hiding this comment.
Most @jtojnar comments are fixed, and the packages builds and runs (didn't test if it works though, since I don't have a scanner with me).
There is some warnings in orcfeeder-cli though:
/nix/store/vr7slhwvp7xwwn2893fif8zx2splq156-ocrfeeder-0.8.3/lib/python3.8/site-packages/ocrfeeder/util/lib.py:25: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
from gi.repository import Gtk
Usage: .ocrfeeder-cli-wrapped -i IMAGE1 [-i IMAGE2, ...] -o FILE
.ocrfeeder-cli-wrapped: error: Please specify the images to be recognized.
I don't think those warnings are blocking, and they mostly depends of upstream fixes anyway so approved.
|
Thanks for the review. |
Motivation for this change
Useful, gnome3 official application for interactive OCR.
NOTE: This depends on #84935 .Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)