Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtemu: init at 2.1 #84941

Merged
merged 1 commit into from Apr 20, 2020
Merged

qtemu: init at 2.1 #84941

merged 1 commit into from Apr 20, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 10, 2020

Motivation for this change

Add QtEmu.

QtEmu is a graphical user interface for QEMU written in Qt.
It has the ability to run virtual operating systems on native systems.
This way you can easily test a new operating system or try a Live CD on your system without any troubles and dangers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CloudArtAdmins
Copy link
Contributor

works for me.

Ma27
Ma27 requested changes Apr 11, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap the binaries to make sure that the qemu-* executables are found.

pkgs/applications/virtualization/qtemu/default.nix Show resolved Hide resolved
@romildo
Copy link
Contributor Author

romildo commented Apr 11, 2020

Please wrap the binaries to make sure that the qemu-* executables are found.

Done.

@romildo
Copy link
Contributor Author

romildo commented Apr 16, 2020

@Ma27 Is it ok now?

@romildo romildo merged commit 6dd72ea into NixOS:master Apr 20, 2020
@romildo romildo deleted the upd.qtemu branch April 20, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @CloudArtAdmins @Ma27