Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan9port: 2019-02-25 -> 2020-01-08 #84920

Merged
merged 2 commits into from Apr 20, 2020
Merged

plan9port: 2019-02-25 -> 2020-01-08 #84920

merged 2 commits into from Apr 20, 2020

Conversation

eraserhd
Copy link
Contributor

Motivation for this change

Fixes and some minor new features.

Note this is the newest version that supports Darwin 10.12; the next
commit removes that support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • osxsnarf
    • tmuxPlugins.plumb
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    Lost the information, but something like 4000 bytes difference
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @AndersonTorres @bbarker @ftrvxmtrx @KoviRobi

@bhipple
Copy link
Contributor

bhipple commented Apr 10, 2020

Looks like it doesn't support aarch64 either; let's mark meta.platforms with linux and darwin only?

@eraserhd
Copy link
Contributor Author

It is supposed to be portable -- for some definition of portable. I removed aarch64-linux explicitly.

@KoviRobi
Copy link
Contributor

If we use at least 9fans/plan9port@0237dec then it might compile on aarch64? (9fans/plan9port#363)

@Mic92
Copy link
Member

Mic92 commented Apr 20, 2020

Result of nixpkgs-review pr 84920 1

2 packages built:
- plan9port
- tmuxPlugins.plumb

@Mic92 Mic92 merged commit 5e76bf7 into NixOS:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoviRobi KoviRobi Awaiting requested review from KoviRobi

@bbarker bbarker Awaiting requested review from bbarker

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@ftrvxmtrx ftrvxmtrx Awaiting requested review from ftrvxmtrx

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eraserhd @bhipple @KoviRobi @Mic92