Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nat: substitute iptables for compat under nftables #84949

Closed
wants to merge 1 commit into from
Closed

nixos/nat: substitute iptables for compat under nftables #84949

wants to merge 1 commit into from

Conversation

bqv
Copy link
Contributor

@bqv bqv commented Apr 10, 2020

Motivation for this change

Currently, NAT will not work if you have nftables enabled (and therefore default firewall disabled (and therefore ip_tables unloaded/blacklisted)). This allows those using nftables to enable nat and have it work with minimal code change, thanks to the good work of those who created iptables-nftables-compat.

Debugging why my containers had no network access was a pain, this change fixed my issue, I'm using it right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmilata
mmilata suggested changes Apr 17, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for moving towards nftables! Can we use config.networking.firewall.package instead of hardcoding the package name?

Also, there's another reference to pkgs.iptables further down in nat.nix, shouldn't it be replaced as well?

@bqv bqv mentioned this pull request Apr 17, 2020
Closed
10 tasks
@bqv
Copy link
Contributor Author

bqv commented Apr 17, 2020

@mmilata Thanks, updated in the new PR :D I have to give up on this one because I deleted my fork by accident and now it's unlinked, so I can't push to it

@bqv bqv closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bqv @mmilata