Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update imapfilter.nix #84912

Merged
merged 1 commit into from Apr 13, 2020
Merged

Update imapfilter.nix #84912

merged 1 commit into from Apr 13, 2020

Conversation

NorfairKing
Copy link
Contributor

Fix #78304
See lefcha/imapfilter#201

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I use it this way myself and it seems to work..

jonringer
jonringer reviewed Apr 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

if your case, the commit message should be:

imapfilter: add SSLCAFILE make flag

or something similar

@jonringer
Copy link
Contributor

Also, thank you for opening a PR :)

@NorfairKing
Copy link
Contributor Author

@jonringer I just used the github UI :p

I'll see what I can do.

@jonringer
Copy link
Contributor

in git it would just be:

git commit --amend
# change statement
# save
git push ... ... --force

@NorfairKing
Copy link
Contributor Author

I think I figured it out. Does this satisfy the requirements?
(I had some trouble finding the branch)

jonringer
jonringer approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/84912
1 package built:
imapfilter

@jonringer jonringer merged commit d0034d1 into NixOS:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imapfilter is broken
2 participants
@NorfairKing @jonringer