pythonPackages.limnoria: Add optional dependencies and enable tests #84989
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Apr 13, 2020
progval
force-pushed
the
limnoria-tests
branch
2 times, most recently
from
c0b61ce to
0846080
Compare
|
Thanks for the review, and sorry for the late reply, I missed the notification somehow. This should be fixed now. |
SuperSandro2000
requested changes
Nov 28, 2020
progval
force-pushed
the
limnoria-tests
branch
from
3e93593 to
f099d94
Compare
|
Result of 2 packages built:
|
|
Result of 2 packages failed to build:
Maybe disable the tests for darwin: |
|
Hmm, besides the "Operation not permitted" ones, they look like actual bugs, though. |
|
@SuperSandro2000 If you don't mind, could you re-run them with the |
Not necessary. |
|
I know, but it only explains the |
You can just mark it broken on darwin if you do not want to deal with this now. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Heh, I can't find a Darwin machine to debug, so let's mark it as broken. How do I do it? |
stale
bot
removed
the
2.status: stale
You probably want to set meta.broken = stdenv.isDarwin if you want to mark it broken on darwin. |
SuperSandro2000
requested changes
Jun 12, 2021
These dependencies are optional at runtime, but nice to have. They are already required to run all tests. They are all listed in the source 'requirements.txt' file.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
SuperSandro2000
requested changes
Jun 15, 2021
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
SuperSandro2000
changed the title
SuperSandro2000
changed the title
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages failed to build and are new build failures:
|
SuperSandro2000
requested changes
Jun 16, 2021
| --replace "version=version" 'version="${version}"' | ||
| substituteInPlace plugins/Unix/test.py \ | ||
| --replace "/bin/ls" "ls" \ |
There was a problem hiding this comment.
======================================================================
FAIL: testCall (Unix.test.UnixTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/nix/store/xwq92vhldzyh6m39jbhx7z985yhf8h03-python3.8-limnoria-2021.03.13/lib/python3.8/site-packages/supybot/test.py", line 214, in runTest
originalRunTest()
File "./plugins/Unix/test.py", line 171, in testCall
self.assertNotError('unix call /bin/ls /')
File "/nix/store/xwq92vhldzyh6m39jbhx7z985yhf8h03-python3.8-limnoria-2021.03.13/lib/python3.8/site-packages/supybot/test.py", line 358, in assertNotError
self.assertFalse(m.args[1].startswith('Error:'),
AssertionError: True is not false : 'unix call /bin/ls /' errored: Error: It seems the requested command was not available ([Errno 2] No such file or directory: '/bin/ls').
======================================================================
FAIL: testShellForbidden (Unix.test.UnixTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/nix/store/xwq92vhldzyh6m39jbhx7z985yhf8h03-python3.8-limnoria-2021.03.13/lib/python3.8/site-packages/supybot/test.py", line 214, in runTest
originalRunTest()
File "./plugins/Unix/test.py", line 176, in testShellForbidden
self.assertNotError('unix call /bin/ls /')
File "/nix/store/xwq92vhldzyh6m39jbhx7z985yhf8h03-python3.8-limnoria-2021.03.13/lib/python3.8/site-packages/supybot/test.py", line 358, in assertNotError
self.assertFalse(m.args[1].startswith('Error:'),
AssertionError: True is not false : 'unix call /bin/ls /' errored: Error: It seems the requested command was not available ([Errno 2] No such file or directory: '/bin/ls').
----------------------------------------------------------------------
Ran 1029 tests in 216.732s
FAILED (failures=2, skipped=14)
There was a problem hiding this comment.
what's wrong with the substitution?
SuperSandro2000
requested changes
Jun 17, 2021
| ]; | ||
|
|
||
| checkPhase = '' | ||
| python scripts/supybot-test --no-network test --plugins-dir=./plugins/ |
There was a problem hiding this comment.
Suggested change
| python scripts/supybot-test --no-network test --plugins-dir=./plugins/ | |
| ${python.interpreter} scripts/supybot-test --no-network test --plugins-dir=./plugins/ |
| --replace "version=version" 'version="${version}"' | ||
| substituteInPlace plugins/Unix/test.py \ | ||
| --replace "/bin/ls" "ls" \ |
|
@ofborg build python3Packages.limnoria |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Limnoria has optional features enabled when these dependencies are available.
Things done
I copied dependencies from the source requirements.txt file.
I also enabled tests while I was at it, but I can remove them if you think it's too much overhead (5 to 10 min on an average PC)
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after): 109MB -> 171MBcc @cillianderoiste