Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

principia_make #5

Merged
merged 3 commits into from
Apr 10, 2020
Merged

principia_make #5

merged 3 commits into from
Apr 10, 2020

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Apr 10, 2020

No description provided.

PRINCIPIA_MACOS_C_FLAGS=

principia_configure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I would like to separate this file in two bits at this line: everything below should be executed in the pipeline as part of the Make task group with variable overrides. Everything above effectively simulates what the pipeline does. (And some if-this-then-that needs to happen.)

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These flags are only used within the make task, so we should try to override them in one place and not three.

Perhaps they should be removed from the variable group, but that is a different question.

Sorry, something went wrong.

@eggrobin eggrobin merged commit ea41b18 into mockingbirdnest:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants