llvmPackages: 7 -> 10 #85034
llvmPackages: 7 -> 10 #85034
Conversation
|
@ofborg eval |
There was a problem hiding this comment.
Thanks for this PR, but the approach might unfortunately a bit too simplistic (though I haven't had a closer look yet).
Why on earth is llvmPackages still pointing at 7?
Most likely because it's a lot of work to switch the default. You basically need to rebuild all reverse dependencies (could easily be a few thousand packages, but I haven't actually checked this), determine which ones break due to this changes, and fix the breakages and/or notify the maintainers.
Testing this change probably requires a beefy machine for nixpkgs-review or a dedicated Hydra jobset.
Regarding this PR: The commits should be squashed (but this can also be done when merging) and after determining the number of rebuilds this causes it might have to go into staging (which seems like a good idea anyway, but in case it causes only a few rebuilds as we built most packages with GCC it might theoretically be ok for master as well).
Anyway this is basically just a quick FYI / heads up that nixpkgs-review is a requirement for this PR (or a Hydra jobset if this causes too many rebuilds).
|
Thanks. My machine probably isn't strong enough to run that! This was entirely a test to see how many packages would be affected by this, since at a glance, most that use llvmPackages seem to pin a particular version anyway - I never intended for this to be merged :) |
Motivation for this change
Testing the effect of this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)