Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghidra: 9.1 -> 9.1.2 #84925

Merged
merged 1 commit into from Apr 18, 2020
Merged

ghidra: 9.1 -> 9.1.2 #84925

merged 1 commit into from Apr 18, 2020

Conversation

NilsIrl
Copy link
Member

@NilsIrl NilsIrl commented Apr 10, 2020

Motivation for this change

Update ghidra.

Move icoutils from buildInputs to nativeBuildInputs because it is a
compile time dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NilsIrl NilsIrl force-pushed the ghidra_9.1.2 branch 2 times, most recently from 36df12a to 938db76 Compare April 10, 2020 18:21
@NilsIrl
Copy link
Member Author

NilsIrl commented Apr 10, 2020 •
edited

CC @ck3d

@NilsIrl
ghidra: 9.1 -> 9.1.2
ec88246 
Move icoutils from buildInputs to nativeBuildInputs because it is a
compile time dependency.
@NilsIrl
Copy link
Member Author

NilsIrl commented Apr 10, 2020

I'm not exactly sure how I messed this up, but now, it should be back to normal.

@ofborg ofborg bot requested a review from ck3d April 10, 2020 21:34
@bhipple bhipple mentioned this pull request Apr 18, 2020
Closed
10 tasks
@bhipple
Copy link
Contributor

bhipple commented Apr 18, 2020

Result of nixpkgs-review pr 84925 1

1 package built:
- ghidra-bin

@bhipple bhipple merged commit 3d902a8 into NixOS:master Apr 18, 2020
@NilsIrl NilsIrl deleted the ghidra_9.1.2 branch April 19, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@cole-h cole-h cole-h left review comments

@bhipple bhipple bhipple approved these changes

@ck3d ck3d Awaiting requested review from ck3d

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NilsIrl @bhipple @jonringer @cole-h