Skip to content

Consistently use quotes in metadata 'homepage' field #84910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Consistently use quotes in metadata 'homepage' field #84910

wants to merge 1 commit into from
+9,511 −9,511

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@raboof
Consistently use quotes in metadata 'homepage' field

Verified

This commit was signed with the committer’s verified signature. The key has expired.
CRBroughton Craig R Broughton
GPG key ID: A9923C0202EEA387
Expired
Verified
Learn about vigilant mode
b463df8
@ofborg ofborg bot added 6.topic: cinnamon Desktop environment 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation labels Apr 10, 2020
@ofborg ofborg bot added 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Apr 10, 2020
@bhipple
Copy link
Contributor

bhipple commented Apr 10, 2020

See discussion in #83909, should probably be handled there?

@raboof
Copy link
Member Author

raboof commented Apr 10, 2020

See discussion in #83909, should probably be handled there?

Thanks for the link, I didn't find that before! Indeed this PR is a subset of that one, and since that one's already rolling I'll close this one.

@raboof raboof closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis

@alyssais alyssais

@cdepillabout cdepillabout

@edwtjo edwtjo

@FRidh FRidh

@infinisil infinisil

@LnL7 LnL7

@matthewbauer matthewbauer

@Mic92 Mic92

@rycee rycee

@ttuegel ttuegel

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: cinnamon Desktop environment 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @bhipple