qimgv: enable video support #84965
Merged
qimgv: enable video support #84965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
force-pushed
the
qimgv
branch
4 times, most recently
from
be6c7ca
to
19e43b8
Compare
|
I tried to play a mp4 but it ...just never did: but |
I actually went back and `strace`'d the binary when it complained about being unable to load the library it uses for playing videos. Turns out, it wasn't finding the library because it wasn't in any of its library paths. I added the lib path to `LD_LIBRARY_PATH` so it can find the library it uses to play videos, and now things are peachy. There is a (seemingly innocuous) error that gets displayed from Exiv2 being unable to determine its image type. Since it's actually a video, I think it's fine. Another issue that pops up in the output is missing `libcuda.so.1`, but that doesn't seem to affect functionality, and using `addOpenGLRunpath` on both the binary and libraries didn't silence it. Also did a little formatting.
msteen
approved these changes
Apr 12, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Result of 1 package built:- qimgv |
bhipple
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually went back and
strace'd the binary when it complained aboutbeing unable to load the library it uses for playing videos. Turns out,
it wasn't finding the library because it wasn't in any of its library
paths. I added the lib path to
LD_LIBRARY_PATHso it can find thelibrary it uses to play videos, and now things are peachy.
There is a (seemingly innocuous) error that gets displayed from Exiv2
being unable to determine its image type. Since it's actually a video, I
think it's fine. Another issue that pops up in the output is missing
libcuda.so.1, but that doesn't seem to affect functionality, and usingaddOpenGLRunpathon both the binary and libraries didn't silence it.Also did a little formatting.
Motivation for this change
I had a bit of free time (read: was procrastinating) and decided to try and figure out why
qimgvwas missing the library it needs to play videos (which it compiles itself). You can read my commit message above, but suffice to say it needs to be able to find the library to load it...Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)