Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mako: wrap with wrapGAppsHook #84969

Merged
merged 2 commits into from Apr 11, 2020
Merged

mako: wrap with wrapGAppsHook #84969

merged 2 commits into from Apr 11, 2020

Conversation

vikanezrimaya
Copy link
Member

@vikanezrimaya vikanezrimaya commented Apr 11, 2020 •
edited

mako wasn't finding the librsvg library and its gdk-pixbuf loader, the SVG icon support was broken for a long time.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vikanezrimaya
mako: wrap with wrapGAppsHook
c6eabc0 
mako wasn't finding the librsvg library and its gdk-pixbuf loader, the
SVG icon support was broken for a long time.
@ofborg ofborg bot requested review from Synthetica9 and dywedir April 11, 2020 03:10
@jtojnar jtojnar merged commit dd0c85d into NixOS:master Apr 11, 2020
@vikanezrimaya vikanezrimaya deleted the mako-svg-icons branch November 8, 2020 09:36
calbrecht added a commit to calbrecht/nixpkgs-wayland that referenced this pull request Oct 2, 2021
@calbrecht
mako: add wrapGAppsHook for svg icons support
3070a70 
Apply change from NixOS/nixpkgs#84969 for svg icons support.
@calbrecht calbrecht mentioned this pull request Oct 2, 2021
Merged
calbrecht added a commit to calbrecht/nixpkgs-wayland that referenced this pull request Oct 2, 2021
@calbrecht
mako: add wrapGAppsHook for svg icons support
465f5e3 
Apply change from NixOS/nixpkgs#84969 for svg icons support.
colemickens pushed a commit to nix-community/nixpkgs-wayland that referenced this pull request Oct 10, 2021
@calbrecht @colemickens
mako: add wrapGAppsHook for svg icons support
aa76140 
Apply change from NixOS/nixpkgs#84969 for svg icons support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vikanezrimaya @jtojnar