Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug_report.md: ask to notify maintainers #84967

Merged
merged 1 commit into from Apr 13, 2020
Merged

bug_report.md: ask to notify maintainers #84967

merged 1 commit into from Apr 13, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

This is really essential thing that everyone should be doing.
A few extra notifications won't hurt anyone, and we should be tracking issues
to connect them to the best people who can handle them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace @cole-h
bug_report.md: ask to notify maintainers
29efd1e 
This is really essential thing that everyone should be doing.
A few extra notifications won't hurt anyone, and we should be tracking issues
to connect them to the best people who can handle them.

Co-Authored-By: Cole Helbling <cole.e.helbling@outlook.com>
@worldofpeace worldofpeace merged commit c609c5a into master Apr 13, 2020
@worldofpeace worldofpeace deleted the worldofpeace-patch-1 branch April 13, 2020 22:03
@worldofpeace
Copy link
Contributor Author

Thanks @cole-h, it's finally your moment for the nitpicks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @cole-h